Add -fdebug-prefix-map command line argument
#5011
Open
+42
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to follow clang, accepting pairs of <old>=<new> paths.
This is required to have reproducible builds without remapping the source code directory to a fixed location (for example in Bazel, where the source code for every build action will end up in a sanbox directory with some hash in the path name). Try to keep the implementation as close as possible to what clang does.
yanok
force-pushed
the
yanok/debug-prefix-map
branch
from
5045485 to
9edb6d4
Compare
JohanEngelen
reviewed
Nov 1, 2025
|
|
||
| std::string DIBuilder::remapDIPath(llvm::StringRef path) { | ||
| for (const auto &[from, to] : opts::debugPrefixMap) { | ||
| if (path.starts_with(from)) { |
There was a problem hiding this comment.
starts_with looks dangerous, what if I map "some/path="other/thing", does that mean that "some/path_more" also matches and is remapped?
There was a problem hiding this comment.
(could be checked in a test case)
There was a problem hiding this comment.
Yes, but this is what clang does. I guess in the most (only?) use cases this is going to be some "root" path, so we don't expect sources from root_some to be passed to the compiler. Cautious people can do some/path/=other/thing/. It's easy to enforce this in the code, but I don't want to diverge from clang...
|
Don't forget to add testcase(s) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug info stores the path to the directory where the source is located and that causes problem with getting reproducible build results if ran from different work directories.
Traditionally people solve that by controlling the build environment, such that sources are always at the fixed location. But this can sometimes be undesirable (for example with bazel, where each build action runs in a sandbox with a hash in the path name), so clang supports the
-fdebug-prefix-mapoption to control this.This PR implement the same option in LDC.